From 1a2ac653d7d8b9d39d541ac6c9b58ce70accc3ec Mon Sep 17 00:00:00 2001 From: Alek Ratzloff Date: Sun, 17 Jul 2022 15:47:46 -0700 Subject: [PATCH] Fix /banned/ page redirect error The URL routing for /banned/ was going to the board controller because it would match /banned/ as a board URL rather than its verbatim value. This is fixed by moving the board route match to the bottom of the URL routing list. Signed-off-by: Alek Ratzloff --- board/urls.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/board/urls.py b/board/urls.py index ecf3aa7..704fcd7 100644 --- a/board/urls.py +++ b/board/urls.py @@ -9,13 +9,6 @@ app_name = "board" urlpatterns = [ # News views path("news/", NewsListView.as_view(), name="board_news"), - # Board views - path("/", BoardView.as_view(), name="board_detail"), - path("/page//", BoardView.as_view(), name="board_detail"), - path("/post//", PostView.as_view(), name="post_detail"), - path("/post/create/", PostCreateView.as_view(), name="post_create"), - path("/reply//", ReplyCreateView.as_view(), name="reply_create"), - path("post/success/", PostSuccessView.as_view(), name="post_success"), # Reports path("report///", ReportView.as_view(), name="report_form"), path( @@ -49,6 +42,14 @@ urlpatterns = [ ActionSuccessView.as_view(window_timeout=settings.ACTION_SUCCESS_CLOSE_TIMEOUT), name="post_delete_success", ), + # Board views + path("post/success/", PostSuccessView.as_view(), name="post_success"), + path("/page//", BoardView.as_view(), name="board_detail"), + path("/post//", PostView.as_view(), name="post_detail"), + path("/post/create/", PostCreateView.as_view(), name="post_create"), + path("/reply//", ReplyCreateView.as_view(), name="reply_create"), + # This has to go very last, so that things like banned/ page works + path("/", BoardView.as_view(), name="board_detail"), ] # TODO - make this conditional so we can serve images up with whatever server we want urlpatterns += static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)